feat: remove loop closures that capture mutable variables#1020
Merged
anmonteiro merged 3 commits intomainfrom Feb 7, 2024
Merged
feat: remove loop closures that capture mutable variables#1020anmonteiro merged 3 commits intomainfrom
anmonteiro merged 3 commits intomainfrom
Conversation
anmonteiro
force-pushed
the
anmonteiro/emit-let
branch
from
55a9897 to
740d674
Compare
anmonteiro
force-pushed
the
anmonteiro/turn-off-closures-in-loops
branch
from
7c99f7a to
2975606
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #1019, which is a pre-requisite. Since
letis block-scoped (whereasvaris function-scoped), we don't need to capture these mutable loop variables in an IIFE anymore.This is a port of rescript-lang/rescript#6480 to Melange